Resent-Date: Fri, 23 Oct 1998 10:06:52 +0200 (MET DST) Date: Fri, 23 Oct 1998 10:07:49 +0200 (MET DST) From: Roman Hodek To: linux-m68k@lists.linux-m68k.org Subject: [cpeterso@microsoft.com: ACSI driver for Linux 2.1.125] Reply-to: Roman.Hodek@informatik.uni-erlangen.de Resent-From: linux-m68k@phil.uni-sb.de No there are already Linux hackers at Microsoft :-) Today I received the following: ------- Start of forwarded message ------- From: Christopher Peterson To: "'Roman.Hodek@informatik.uni-erlangen.de'" Subject: ACSI driver for Linux 2.1.125 Date: Thu, 22 Oct 1998 17:59:40 -0700 I found a bug in your ACSI driver when running a Lint script over the Linux 2.1.125 source tree: C:\linux-2_1_125\linux\drivers\block\acsi.c (line 1346): if (XXX); if (acsi_wait_for_noIRQ( 20 ) && acsicmd_nodma( modesense_cmd, 0 ) && acsi_wait_for_IRQ( 3*HZ ) && acsi_getstatus() == 0); <-- extra semicolon!! break; good luck! chris ------- End of forwarded message ------- The patch is ok, below in a sane format. I guess diff hasn't been invented yet in Redmond :-) Roman ------------------------------------------------------------------------------ --- linux-2.1.120/drivers/block/acsi.c~ Fri Aug 28 21:31:08 1998 +++ linux-2.1.120/drivers/block/acsi.c Fri Oct 23 10:07:15 1998 @@ -1343,7 +1343,7 @@ if (acsi_wait_for_noIRQ( 20 ) && acsicmd_nodma( modesense_cmd, 0 ) && acsi_wait_for_IRQ( 3*HZ ) && - acsi_getstatus() == 0); + acsi_getstatus() == 0) break; } if (page == 4) {